This project is archived and is in readonly mode.
Add :from scoping respect to Calculations module
Calculations do not respect :from scopings. (The do now respect :from as an option.)
class Node < ActiveRecord::Base
named_scope :old_nodes, { :from => 'old_nodes' }
end
Node.old_nodes.average(:value)
executes:
SELECT avg("nodes".value) AS avg_value FROM "nodes"
it should respect the scope and execute:
SELECT avg("nodes".value) AS avg_value FROM "old_nodes"
I've attached a fix.
-
Pratik- Milestone cleared.
- State changed from new to incomplete
- Assigned user set to Pratik
Looks good. Missing tests.
Thanks.
-
CancelProfileIsBroken- Tag changed from activerecord, calculations, named_scope, patch, scope to activerecord, bugmash, calculations, named_scope, patch, scope
-
Matt Duncan
+1 Although I don't see a lot of use-cases for this I think it's good to be consistent. I've added a test, if anyone has thoughts on how this could be better tested please let me know.
I've attached a patch.
-
1229.diff
2.37 KB
-
-
José Valim- Assigned user changed from Pratik to Michael Koziarski
- State changed from incomplete to new
-
Matt Duncan
#2823 Calculations break with multi-column :select argument is related to this also
-
-
Jeremy Kemper
(+1 though)
-
-
-
Jeremy Kemper
Ah, Michael already committed this but didn't cherry-pick to 2-3-stable.
-
Steve St. Martinso does this need a patch against 2-3-stable?
-
Michael KoziarskiYes I did... github's just way behind.
-
Michael Koziarski
- Tag changed from activerecord, bugmash, calculations, named_scope, patch, scope to activerecord, calculations, named_scope, patch, scope
- State changed from open to resolved
-
Repository
- State changed from resolved to committed
(from [3b3798506b403911665c3c24fd055b75d6f6a44f]) Adding :from scoping to ActiveRecord calculations
Signed-off-by: Michael Koziarski michael@koziarski.com
[#1229 Add :from scoping respect to Calculations module state:committed] http://github.com/rails/rails/commit/3b3798506b403911665c3c24fd055b... -
Repository
(from [45f5bdfbc7fc1ee1fbc23525a112062c8b31d539]) Adding :from scoping to ActiveRecord calculations
Signed-off-by: Michael Koziarski michael@koziarski.com
[#1229 Add :from scoping respect to Calculations module state:committed] http://github.com/rails/rails/commit/45f5bdfbc7fc1ee1fbc23525a11206...