This project is archived and is in readonly mode.
[Patch] OrderedHash does not sync it's @keys after mutating operations.
Here's a patch which fixes this for #delete_if, #reject!, and #reject.
This probably holds true for any other mutating method, I haven't gone through them all except these which I needed.
If the recent change to OrderedHash, to subclass Hash, was a speed improvement; would it still be so after fixing all mutating methods like these?
-
ordered_hash.diff
2.51 KB
-
-
Frederick CheungSpeed things up a little and cover some of the other mutators
-
ordered_hash_additions.patch
4.02 KB
-
-
Frederick Cheung
- State changed from resolved to open
-
Repository- State changed from open to committed
(from [6eed6cf5c6db0dbf96c1c2756eb946f54277a0cb]) Make delete_if/reject faster and fix other mutators
[#1559 [Patch] OrderedHash does not sync it's @keys after mutating operations. state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
-
Repository
(from [4dcd8f01afe5800baa67bbdf72832afb0d627755]) Make delete_if/reject faster and fix other mutators
[#1559 [Patch] OrderedHash does not sync it's @keys after mutating operations. state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...