Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

SQLite 2 Adapter should not try to add columns while in a transaction

#1669

The SQLite3 adapter checks before trying to add a column to a table that we're not already in a transaction (which causes the add to fail). SQLite2 adapter does not. This causes test_sqlite_add_column_in_transaction_raises_statement_invalid to fail under SQLite2 only. Attached patch adds the check for SQLite2.

Reported by CancelProfileIsBroken · December 30th, 2008 @ 02:49 AM

State: resolved
Milestone: 2.x
Assigned to: Pratik Pratik
Importance: none

Activity

  1. Repository
    Repository
    • State changed from new to resolved

    (from [220dff4c3b58b7becb587ee6f2434b2ca720f7c3]) Add transaction check to SQLite2 adapter to fix test_sqlite_add_column_in_transaction_raises_statement_invalid [#1669 SQLite 2 Adapter should not try to add columns while in a transaction state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    December 30th, 2008 @ 03:18 AM

  2. Repository
    Repository

    (from [abfa46e3a6ba0e91f377a073d208f31f99a7a008]) Add transaction check to SQLite2 adapter to fix test_sqlite_add_column_in_transaction_raises_statement_invalid [#1669 SQLite 2 Adapter should not try to add columns while in a transaction state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    February 2nd, 2009 @ 07:57 PM