This project is archived and is in readonly mode.
Make rake gems:build respect Rails.env
If gems are configured in config/environments/test.rb and "rake gems:build" is run in the production environment, the gems configured for the test environment are built. This forces the production machine to have the necessary libraries installed to build all gems used for testing.
This patch updates "rake gems:build" to only build gems configured for the current Rails.env.
-
gems_build.diff
1.66 KB
-
Pratik- Tag changed from gems, rake to gems, patch, rake
- Assigned user set to Matt Jones
-
José Valim+1
-
Matt Jones-1 on this; haven't tested it, but it will most likely cause some spectacular failures in edge cases. Notably, one of the primary gems that needs building in many apps is RedCloth; it gets pulled in by Rails under some conditions on loading the environment, and dies messily (Bus error, on OSX) if the native support isn't present. That's the whole reason that the environment isn't loaded by the gems:build task...
This is really part of #1721 Unify approach to gem dependencies; the whole idea needs to be restructured.
-
David DollarThis should no longer be an issue as of 2.3
-
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale