Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

This project is archived and is in readonly mode.

to_sentence breaks api

#1847

The new words_connector args are great for moving forward, but if you use the Rails 2.2 era to_sentence(:connector => "or") param hash you get errors. Ideally, this should be deprecated, but the old :connector should be mapped to :words_connector in the interim.

Reported by Niels Meersschaert · February 2nd, 2009 @ 08:38 PM

State: committed
Milestone: none
Assigned to: Sven Fuchs Sven Fuchs
Importance: Medium

Activity

  1. DHH
    DHH
    • Milestone cleared.

    February 6th, 2009 @ 02:06 PM

  2. Guillermo Álvarez
    Guillermo Álvarez
    • Tag changed from 2.3, active_support to 2.3, active_support, i18n, patch, tested

    Posible solution with tests

    February 7th, 2009 @ 06:19 PM

  3. Fernando Guillen
    Fernando Guillen

    +1, well done

    February 7th, 2009 @ 10:43 PM

  4. porras
    porras

    +1, tests pass

    February 7th, 2009 @ 10:43 PM

  5. Luismi Cavallé
    Luismi Cavallé

    +1, Tests pass

    February 7th, 2009 @ 10:43 PM

  6. Yaroslav Markin
    Yaroslav Markin
    • Assigned user set to Sven Fuchs

    +1

    February 8th, 2009 @ 08:51 AM

  7. Repository
    Repository
    • State changed from new to committed

    (from [ff1afbd65098643a06eef928f92fecf6e9d548b2]) Deprecated warnings for :skip_last_command and :connector of to_sentence [#1847 to_sentence breaks api state:committed]

    Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...

    February 22nd, 2009 @ 03:13 PM