This project is archived and is in readonly mode.
Bug using response.headers["expires"]
Just upgraded our project to edge Rails and we saw an exception using response.headers["expires"]. We looked at the code and found the problem. I have attached the patch. Is this actually a bug? Could we get it in before 2.3 is final?
Thanks! Joe Fiorini
-
header-expires.diff
862 Bytes
-
josh- Milestone cleared.
- Assigned user set to josh
-
josh
- State changed from new to open
Could you please attach a unit test as well.
Actually, I think we could omit that entire method. Rack should be normalizing the header keys so it shouldn't really matter in this case.
Can you try to reproduce the error and see if removing the method altogether will fix it too?
-
Repository- State changed from open to resolved
(from [0096eb1555a3e61e89ff90eddefdc28739adc618]) Removed dead convert_expires! in Response [#1952 state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
-
Joe F.Thanks for taking care of this! Sorry I never updated my patch, this was my first submission and I wasn't sure where to put the test. Where exactly did you put the test for this? I'd like to take a look at it so I have a better idea next time.