Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Han Kessels March 28th, 2009 @ 07:40 AM

  • Tag changed from “2.2.2, ie, submit_tag” to “2.2.2, ie, patch, submit_tag”

  Here is a patch. Instead of cloning the button element and changing it's type, it simply creates a new hidden element and copies name and value. Test updates are included.

  See also here

  • disable_with_patch.diff 6.3 KB
• 

  Michael Koziarski April 27th, 2009 @ 09:31 AM

  • Assigned user set to “Michael Koziarski”
  • Milestone cleared.

• You flagged this item as spam.
  

  Han Kessels May 24th, 2009 @ 03:28 AM

  Thanks Michael.

  It would be great if this patch could land in the next 2.3.x release.

• 

  Michael Koziarski May 26th, 2009 @ 11:59 AM

  Are name and value sufficient? It could mess up formatting stuff if we don't copy classes, etc right?

  Which versions of IE does this break in?

• You flagged this item as spam.
  

  Han Kessels May 26th, 2009 @ 12:15 PM

  It breaks in IE6, 7 and 8.

  The new element is a hidden input element, so formatting will not be affected. Its only purpose is to pass along the button's value on submit, so name and value should be all that is needed.

• 

  Michael Koziarski June 1st, 2009 @ 03:06 AM

  • State changed from “new” to “committed”

  Pushed to 2-3-stable and master. Is #633 ok now too?

• You flagged this item as spam.
  

  Han Kessels June 1st, 2009 @ 07:53 AM

  • Tag changed from “2.2.2, ie, patch, submit_tag” to “2-3-stable, ie, patch, submit_tag”

  Thanks!

  #633 is good too.