Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Han Kessels's latest activity

Monday, June 01 2009
1955 :disable_with option to submit_tag() doesn't work with IE was updated in Ruby on Rails
  • Han Kessels
    • Tag changed from 2.2.2, ie, patch, submit_tag to 2-3-stable, ie, patch, submit_tag
    by Han Kessels at 7:53 AM

    Thanks!

    #633 is good too.

Tuesday, May 26 2009
1955 :disable_with option to submit_tag() doesn't work with IE was updated in Ruby on Rails
  • Han Kessels
    Han Kessels commented at 12:15 PM

    It breaks in IE6, 7 and 8.

    The new element is a hidden input element, so formatting will not be affected. Its only purpose is to pass along the button's value o...

Sunday, May 24 2009
1955 :disable_with option to submit_tag() doesn't work with IE was updated in Ruby on Rails
  • Han Kessels
    Han Kessels commented at 3:28 AM

    Thanks Michael.

    It would be great if this patch could land in the next 2.3.x release.

Saturday, March 28 2009
1955 :disable_with option to submit_tag() doesn't work with IE was updated in Ruby on Rails
  • Han Kessels
    • Tag changed from 2.2.2, ie, submit_tag to 2.2.2, ie, patch, submit_tag
    by Han Kessels at 7:40 AM

    Here is a patch. Instead of cloning the button element and changing it's type, it simply creates a new hidden element and copies name and value. Test updates ar...

Friday, March 27 2009
633 FormTagHelper#submit_tag with :disable_with option doesn't submit the button'... was updated in Ruby on Rails
  • Han Kessels
    Han Kessels commented at 7:20 AM

    This patch breaks the :disable_with option on all versions of Internet Explorer.

    IE does not allow the modification of the type attribute of an element. This ca...