#2011 assert_template :symbol passes whatever - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2011 ✓resolved

assert_template :symbol passes whatever

Reported by Mark Dodwell | February 18th, 2009 @ 09:36 PM | in 2.x

When you use a symbol for assert_template, it passes regardless of what symbol you pass.

For example, if the actual template rendered is 'foo/new.html.erb', then the following will happen:

Is this intended behaviour, or a bug?

Thanks,

~ Mark

You flagged this item as spam.
Mike Breen March 16th, 2009 @ 01:11 AM
- Tag changed from “2.3-rc1, assert_template, testunit” to “2.3-rc1, assert_template, patch, testunit”
The attached patch adds:
- basic tests for existing assert_template functionality
- assert_template can now accept a Symbol argument
- assert_template raises an ArgumentError if passed something other than String, Nil, Symbol or Hash
- add_tests_to_assert_test_and_allow_symbol_arg.diff 5.2 KB
CancelProfileIsBroken March 16th, 2009 @ 01:37 AM
- State changed from “new” to “open”
- Assigned user set to “Pratik”
Patch + tests work fine for me on edge. +1
Pratik March 16th, 2009 @ 01:41 AM
- Should use get instead of process
- Should rebase all the commits into a single commit
Thanks
You flagged this item as spam.
Mike Breen March 16th, 2009 @ 11:24 AM
- Assigned user cleared.
I've updated the patch to use get instead of process and put it into a single commit.
- assert_template_with_symbol.diff 3.5 KB
You flagged this item as spam.
Mike Breen March 16th, 2009 @ 11:26 AM
- Assigned user set to “Pratik”
Repository May 17th, 2009 @ 06:49 PM
- State changed from “open” to “resolved”
(from [f383a4aa333cd8a99003eb1bdbb27b6fdea1056c]) Allow assert_template to take a symbol [#2011 state:resolved]

Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/f383a4aa333cd8a99003eb1bdbb27b...