This project is archived and is in readonly mode.
I18n :prompt message for select helpers
-
Sven Fuchs
- Assigned user set to Sven Fuchs
-
Sven Fuchs
- State changed from new to open
- Milestone changed from 2.x to 2.3.4
Thanks Akira!
Ok, I've (manually) rebased the patch on 2-3-stable and moved the translation from select.prompt to support.select.prompt
Should be applied imo, it's kind of a no-brainer :)
-
Repository
- State changed from open to committed
(from [d725ad39da4436bded05cb647b930e5597c8771c]) I18n: use I18n for select helpers' prompt text
[#2252 I18n :prompt message for select helpers state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/d725ad39da4436bded05cb647b930e... -
Repository
(from [adedf72821a5623227ce91e6b298838e692477e4]) I18n: use I18n for select helpers' prompt text
[#2252 I18n :prompt message for select helpers state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/adedf72821a5623227ce91e6b29883... -
Jeremy Kemper
- State changed from committed to open
Did I miss something?
1) Failure: test_select_with_default_prompt(FormOptionsHelperTest) [./test/../lib/action_controller/test_case.rb:114:in `clean_backtrace' ./test/template/form_options_helper_test.rb:371:in `test_select_with_default_prompt' ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__' ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `run']: <"<select name=\"post[category]\" id=\"post_category\"><option value=\"\">Please select</option>\n<option value=\"abe\">abe</option>\n<option value=\"<mus>\"><mus></option>\n<option value=\"hest\">hest</option></select>"> expected to be == to <"<select name=\"post[category]\" id=\"post_category\"><option value=\"\">Select!</option>\n<option value=\"abe\">abe</option>\n<option value=\"<mus>\"><mus></option>\n<option value=\"hest\">hest</option></select>">. 2) Failure: test_select_with_prompt_and_blank(FormOptionsHelperTest) [./test/../lib/action_controller/test_case.rb:114:in `clean_backtrace' ./test/template/form_options_helper_test.rb:398:in `test_select_with_prompt_and_blank' ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__' ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `run']: <"<select name=\"post[category]\" id=\"post_category\"><option value=\"\">Please select</option>\n<option value=\"\"></option>\n<option value=\"abe\">abe</option>\n<option value=\"<mus>\"><mus></option>\n<option value=\"hest\">hest</option></select>"> expected to be == to <"<select name=\"post[category]\" id=\"post_category\"><option value=\"\">Select!</option>\n<option value=\"\"></option>\n<option value=\"abe\">abe</option>\n<option value=\"<mus>\"><mus></option>\n<option value=\"hest\">hest</option></select>">. -
Sven Fuchs
Man. I swear they passed. I'll look into it.
-
Repository
(from [3cd245b7fa8bf6afea1c41af503a6a1db28450a9]) Revert "I18n: use I18n for select helpers' prompt text"
Broke CI.
[#2252 I18n :prompt message for select helpers state:open]
This reverts commit d725ad39da4436bded05cb647b930e5597c8771c.
http://github.com/rails/rails/commit/3cd245b7fa8bf6afea1c41af503a6a... -
Repository
(from [a7ca5595a21fa3bfd0ef51e6a56fbb80a13e040b]) Revert "I18n: use I18n for select helpers' prompt text"
Broke CI.
[#2252 I18n :prompt message for select helpers state:open]
This reverts commit adedf72821a5623227ce91e6b298838e692477e4.
http://github.com/rails/rails/commit/a7ca5595a21fa3bfd0ef51e6a56fbb... -
Jeremy Kemper
I swore I ran tests too! But it was against the other patch.
-
Sven Fuchs
Ok, new version of this patch.
I've re-cloned the repo, reapplied the patch and now I got the same errors.
The test did not correctly clean up after itself so a translation was still sticking.
-
Repository
- State changed from open to committed
(from [cc9af20da7af98464ece18d4abc6a22ef3f00b5d]) I18n: use I18n for select helpers' prompt text
[#2252 I18n :prompt message for select helpers state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/cc9af20da7af98464ece18d4abc6a2... -
Repository
(from [e46e67c71f0afd2702b24896c94c56e3ba11a754]) I18n: use I18n for select helpers' prompt text
[#2252 I18n :prompt message for select helpers state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/e46e67c71f0afd2702b24896c94c56... -
Akira Matsuda
Sorry for the broken test, and thank you for your rebasing and fixing work, Sven!
