Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  Luigi Montanez March 18th, 2009 @ 03:06 PM

  This wreaked havoc for me in production. Without those Rack commits in there, all POSTed params were getting blanked out by Rails.

  Please fix ASAP so others don't have to suffer.

• You flagged this item as spam.
  

  Luigi Montanez March 18th, 2009 @ 03:19 PM

  The major problem is that the .tar.gz archive on dev.rubyonrails.org appears to use the tag to create the archive, so it's inconsistent with the gem release. As it now, the archive release contains the nasty bug described above since it doesn't include Rack 1.0.

• 

  Pratik March 18th, 2009 @ 03:56 PM

  • Assigned user set to “DHH”
• 

  CancelProfileIsBroken March 18th, 2009 @ 04:09 PM

  • Assigned user cleared.

  I just downloaded the rails-2.3.2.tar.gz from http://rubyforge.org/frs/?group_..., and that copy does contain the fix to rack loading path from 18eb80ccc7e932f9a6c00462ceaeea648631b120 . That's where the link at http://rubyonrails.org/download sends you for standalone packages. Are you seeing something else?

• You flagged this item as spam.
  

  Luigi Montanez March 18th, 2009 @ 04:13 PM

  Yes, the Rubyforge version is correct.

  What isn't correct is this version:

  http://dev.rubyonrails.org/archi...

  Which is what is called when doing:

  rake rails:freeze:edge RELEASE=2.3.2

  from a Rails app.

• You flagged this item as spam.
  

  Trevor Turk March 18th, 2009 @ 04:17 PM

  I'm not sure about RubyForge, but github looks wrong to me.

  This tag:

  http://github.com/rails/rails/co...

  ...doesn't include some commits:

  http://github.com/rails/rails/co...

  ...that I've been lead to believe:

  http://rails.lighthouseapp.com/p...

  ...are included in the gem, but not the tagged version.

  I'm not sure what impact having the tag on github not match the gem. I'm reporting it because I'm used to being able to freeze my production apps to a tag and/or a stable branch.

• 

  CancelProfileIsBroken March 18th, 2009 @ 04:29 PM

  Right, we know that Github tag doesn't match the gem, and the impact this has on freezing edge. Those issues will be corrected soonish. Just wanted to confirm that there wasn't yet another copy floating around somewhere.

  Until then, use the gem or grab edge straight from GitHub.

• 

  CancelProfileIsBroken March 18th, 2009 @ 04:30 PM

  • Assigned user set to “DHH”
• 

  DHH March 18th, 2009 @ 04:32 PM

  • State changed from “new” to “resolved”

  Added 2.3.2.1 as a fixed tag.

• You flagged this item as spam.
  

  Trevor Turk March 18th, 2009 @ 04:33 PM

  That's great - thanks very much for the quick fix!