This project is archived and is in readonly mode.
[PATCH] Support for loading nested arrays, numbers and symbols in ActiveResource
It appeared that ActiveResource can't load a nested array, only a flat array of strings (and not even array of numbers).
Check out:
# given that person is an ActiveResource object
person.load {:items => [['first', 'black'], ['second', 'red']]
# => ArgumentError: expected an attributes Hash, got ["first", "black"]
The patch attached to the ticket contains a fix and a test case.
Works very well for me. It can load infinitely nested arrays.
-
Ilya SabaninHere is one more patch that adds support for Numbers and Symbols in arrays that ActiveResource can load. Right now you can only load an arrays of strings, nothing else.
That new patch should be after the previous "nested_arrays_support_for_ares.diff" one because it's using the code introduced in that patch.
Tests are also included.
-
Ilya Sabanin
- Title changed from Support for loading nested arrays in ActiveResource to Support for loading nested arrays, numbers and symbols in ActiveResource
-
Ilya Sabanin
- Title changed from Support for loading nested arrays, numbers and symbols in ActiveResource to [PATCH] Support for loading nested arrays, numbers and symbols in ActiveResource
-
Alexey Kovyrin+1 - definitely makes sense to support these
-
Dima Sabanin+1
-
Petyo Ivanov+1
-
-
-
closer+1, I think it is time to fix absurd mistakes and don't move them to 3.x release :)
-
Ilya Sabanin
- Tag changed from active_resource, patch, tested to 2-3-stable, active_resource, patch, tested
-
Zach Brock
- Tag changed from 2-3-stable, active_resource, patch, tested to 2-3-stable, active_resource, patch, tested, verified
-
-
Ilya Sabanin
- Importance changed from to
The problem is not reproducible in Rails 3 anymore, looks like the problem was fixed. We can close this out.
-
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale