#2449 ActionController::Flash::InstanceMethods::flash triggers the lazy sessions - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2449 ✓duplicate

ActionController::Flash::InstanceMethods::flash triggers the lazy sessions

Reported by runa | April 7th, 2009 @ 11:25 PM | in 2.3.9

I've just updated to rails 2.3 and I found that calling flash from the view triggers the lazy sessions. I think this is not the expected behavior.

See the patch attached

Comments and changes to this ticket

You flagged this item as spam.
runa April 8th, 2009 @ 03:00 PM
- Tag set to “2.3.2, flash, lazy, sessions”
- action_controller_flash_triggers_lazy_sessions.diff 522 Bytes
You flagged this item as spam.
Stefan Botzenhart September 23rd, 2009 @ 08:36 AM
Any comments on this ticket? I realized the same thing when trying to cache my application with varnish. As flash triggers the session and sets the "Set-Cookie" header although the session is empty varnish is not willing to cache the page.
You flagged this item as spam.
runa September 23rd, 2009 @ 02:14 PM
Maybe we need to lobby a little for this?
You flagged this item as spam.
Urban Hafner January 29th, 2010 @ 03:15 PM
- Tag changed from “2.3.2, flash, lazy, sessions” to “2.3.2, 2.3.x, flash, lazy, sessions”
Check out this plugin: http://github.com/msales/smart_cookie_store

It enhances the default CookieStore by preventing Set-Cookie headers for empty sessions.
Jeremy Kemper January 29th, 2010 @ 11:51 PM
- Milestone changed from “2.x” to “2.3.6”
- State changed from “new” to “open”
- Assigned user set to “josh”
josh February 2nd, 2010 @ 02:56 PM
- State changed from “open” to “resolved”
I think this is related to:

https://rails.lighthouseapp.com/projects/8994/tickets/3811-empty-se...
You flagged this item as spam.
Urban Hafner February 2nd, 2010 @ 03:00 PM
It is related. How did you fix it? The fix for #3811 isn't enough.
You flagged this item as spam.
Urban Hafner February 5th, 2010 @ 10:02 AM
- Tag changed from “2.3.2, 2.3.x, flash, lazy, sessions” to “2-3-stable, 2.3.2, 2.3.x, 3, 3.0, flash, lazy, sessions”
I had a look and it's not fixed in the latest 2-3-stable. Attached is a diff that contains a test and possible fix (but the fix breaks the reset session functionality). To recap, the problem is that even when you only try to access something in the session (like for example a flash[:notice] in the layout) a session cookie gets set. Even if it is empty and there's no need for it.

I'm not quite sure about Rails 3, but the bug seems to be present there, too.
- test_case_for_bug_2449.diff 2.7 KB
You flagged this item as spam.
Urban Hafner February 5th, 2010 @ 10:03 AM
BTW, sorry for the typo in the test case ;)
You flagged this item as spam.
Urban Hafner February 26th, 2010 @ 01:41 PM
- Tag changed from “2-3-stable, 2.3.2, 2.3.x, 3, 3.0, flash, lazy, sessions” to “2-3-stable, 2.3.2, 2.3.x, 3, 3.0, 3.0pre, flash, lazy, sessions”
I just tested it and the bug is still present in Rails 2.3 (latest version of the branch) and in master. However in master my fix doesn't work (even after the obvious changes necessary to have a look).
Jeremy Kemper June 18th, 2010 @ 11:24 PM
- Milestone changed from “2.3.6” to “2.3.9”
- State changed from “resolved” to “open”
José Valim June 26th, 2010 @ 09:12 AM
- State changed from “open” to “duplicate”
- Importance changed from “” to “”
Fixed on master. When #4938 is backported, this will be fixed as well.