Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Ability to set the filename for inline MIME parts

#2488

This ticket has been in the old trac, with a patch, since december 2007. No comments as to why it should not be committed. Sorry if it has already been addressed, but I couldn't find any matching tickets in this tracker.

http://dev.rubyonrails.org/ticke...

"Setting the filename on an inline MIME part is useful in situations when it's desirable to include some files as inline parts (e.g. inline image, pdf etc): client MUA or webmail then presents the correct filename when the user wants to download the file. Currently, ActionMailer adds the filename parameter for attachments only (part.rb)..."

Patch is attached to that ticket, and applies quite cleanly to edge rails:

patching file test/mail_service_test.rb Hunk #1 succeeded at 135 (offset 10 lines). Hunk #2 succeeded at 769 (offset 57 lines). Hunk #3 succeeded at 830 with fuzz 1 (offset 18 lines). patching file test/fixtures/raw_email14 patching file lib/action_mailer/part.rb Hunk #1 succeeded at 65 with fuzz 1 (offset -5 lines).

and all tests pass, including the new one.

Reported by Chris Wilson · April 13th, 2009 @ 03:40 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 05:03 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 05:03 PM