This project is archived and is in readonly mode.

#3 ✓invalid
Alex Wayne

AssetTagHelper should accept a slightly wider range of protocols

Reported by Alex Wayne | April 15th, 2008 @ 04:31 AM

Forgive me if this is the wrong place. I guessed this URL based on recent news and I see little is here yet. Pardon my butting into this transition...

Before, using

image_tag "data:image/jpeg,base64:ABC123"

Would create an image tag like:

<img src="/images/data:image/jpeg,base64:ABC123" alt="data:image/jpeg,base64:ABC123" />

First, the /images prepended to the data: protocol uri completely breaks it. Second the alt attribute is completely useless, and would be better left out.

This patch allows image_tag to work with inline images via the data: protocol. While obviously not a best practice, it has its uses and image_tag shouldn't fail to work with idiom.

<img src="data:image/jpeg,base64:ABC123" />

It includes 1 additional image_tag assertion that proves its all working as expected.

Comments and changes to this ticket

  • josh

    josh April 20th, 2008 @ 03:12 AM

    • Assigned user set to “josh”
    • State changed from “new” to “open”
    • Title changed from “[PATCH] AssetTagHelper should accept a slightly wider range of protocols” to “AssetTagHelper should accept a slightly wider range of protocols”

    I'm not sure this is a good use of the image_tag method. image_tag tag is there to help you expand image paths and provide you with a "useful" alt tag.

    If you really just want "img src="data:image/jpeg,base64:ABC123"", isn't hard coding the img tag the simplest thing?

  • Cheah Chu Yeow

    Cheah Chu Yeow April 20th, 2008 @ 02:33 AM

    Yup I agree that in this case there is no value using image_tag for inline images and in fact it just makes your page slower calling the image_tag helper when you're not really using any of its functionality.

    -1 (sorry!)

  • josh

    josh April 20th, 2008 @ 03:13 AM

    • State changed from “open” to “invalid”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by