This project is archived and is in readonly mode.
AssetTagHelper should accept a slightly wider range of protocols
Reported by Alex Wayne | April 15th, 2008 @ 04:31 AM
Forgive me if this is the wrong place. I guessed this URL based on recent news and I see little is here yet. Pardon my butting into this transition...
Before, using
image_tag "data:image/jpeg,base64:ABC123"
Would create an image tag like:
<img src="/images/data:image/jpeg,base64:ABC123" alt="data:image/jpeg,base64:ABC123" />
First, the /images prepended to the data: protocol uri completely breaks it. Second the alt attribute is completely useless, and would be better left out.
This patch allows image_tag to work with inline images via the data: protocol. While obviously not a best practice, it has its uses and image_tag shouldn't fail to work with idiom.
<img src="data:image/jpeg,base64:ABC123" />
It includes 1 additional image_tag assertion that proves its all working as expected.
Comments and changes to this ticket
-
josh April 20th, 2008 @ 03:12 AM
- Assigned user set to “josh”
- State changed from “new” to “open”
- Title changed from “[PATCH] AssetTagHelper should accept a slightly wider range of protocols” to “AssetTagHelper should accept a slightly wider range of protocols”
I'm not sure this is a good use of the image_tag method. image_tag tag is there to help you expand image paths and provide you with a "useful" alt tag.
If you really just want "img src="data:image/jpeg,base64:ABC123"", isn't hard coding the img tag the simplest thing?
-
Cheah Chu Yeow April 20th, 2008 @ 02:33 AM
Yup I agree that in this case there is no value using image_tag for inline images and in fact it just makes your page slower calling the image_tag helper when you're not really using any of its functionality.
-1 (sorry!)
-
josh April 20th, 2008 @ 03:13 AM
- State changed from “open” to “invalid”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Alex Wayne
Cheah Chu Yeow
Tags
Referenced by
-
324
Gem dependencies inconsistently load rails/init.rb
Rick, it looks like you've fixed the loading from both t...
-
324
Gem dependencies inconsistently load rails/init.rb
#3, Unpacked, gem still present on system
-
324
Gem dependencies inconsistently load rails/init.rb
After applying the patch to 2.1.1 the spec suite runs fin...
-
1455
ActiveResource Failed With Rails 2.2.1
ActionView::TemplateError (product_url failed to generate...
-
3579
ActiveRecord not setting/checking MySQL session variable time_zone
Because this is a rare, off-the-Rails-way case, I don't t...
-
1825
Using Fixtures docs in API RDoc needs work
However, the default has been to not instantiate instance...
-
1825
Using Fixtures docs in API RDoc needs work
Recommend moving method #3 to be the primary method, and ...
-
2200
reset_session broken
@heidmo - I haven't tested your proposed method, but I do...
-
4006
routes controller block raises "missing :action" arbitrarily between symbol / string
Both cases are invalid although the #3 error message
is b...
-
2488
Ability to set the filename for inline MIME parts
patching file test/mail_service_test.rb Hunk #1 succeeded...
-
4361
has_many through self join does not include table alias, so fails
patching file
activerecord/test/cases/associations/has_ma...
-
5987
RoutingError (No Route Matches) after adding irregular inflector
Showing /home/philip/aircode/app/views/main/index.html.er...
-
5987
RoutingError (No Route Matches) after adding irregular inflector
Extracted source (around line #3):
-
6780
ActionDispatch::RailsMetaStore returns corrupt Rack responses with MemoryStore
All subsequent matches follow #3.
-
6689
Docs for ActiveRecord::Locking::Pessimistic don't make sense
This is addressed in GH #1032 and fixed in #3b18e900e8fc3...