[PATCH] ActionView::TextHelper Graceful Truncate

If you're truncating text with tags, you'd have to make sure that the space you see is not inside of a tag.

Nice tweak, but the implementation is not multibyte compatible.

Thanks for the feedback! I'll work on updating this patch.. now I see it's not ready :)

+1 i've had to insert a method doing that several times on projects.

-1 this functionality exists in master with options[:seperator] and probably should not be backported in a bugfix release

-1 exists and passes tests on master (+ multibyte), tested manually too.

verified on 2-3-stable

ok this time for real

+1 Back port patch applies cleanly on 2-3-stable, tests pass.

+1 The patch applies cleanly on 2-3-stable and the tests pass.

_1 The patch applies cleanly on 2-3 stable and tests pass.

+1 The patch applies cleanly on 2-3 stable and tests pass.

In attempting to create a test case for this identified a bug with ActiveSupport

https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets... , once this ticket is complete the patch can be updated.

I created a working patch for 2-3-stable and master on https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...

Trying to test an RTL input to truncate fails:

def test_truncate_multibyte_with_seperator
   with_kcode 'none' do
     assert_equal "אלעד ...", truncate("אלעד אוכל גזר כתום", :seperator => ' ', :length => 12)
   end
   with_kcode 'u' do
     assert_equal "אלעד ...",
       truncate("אלעד אוכלת גזר כתום", :length => 10, :seperator => ' ')
   end
end
 
 
  1) Failure:
test_truncate_multibyte_with_seperator(TextHelperTest)
    [./test/template/text_helper_test.rb:77:in `test_truncate_multibyte_with_seperator'
     ./test/testing_sandbox.rb:7:in `with_kcode'
     ./test/template/text_helper_test.rb:76:in `test_truncate_multibyte_with_seperator'
     ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__'
     ./test/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `run']:
<"אלעד ..."> expected but was
<"אלעד או...">.

stevestmartin suggests it has something to do with the fact rindex is used, and i used an RTL language as input.

should there be any difference in RTL / LTR languages in this case ?

now that rindex has been corrected, here is a patch with test case to be applied against both 2-3-stable and master as master does not have a test case for this.

previous backport patch still works against 2-3-stable