Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Thursday, August 13 2009
2503 validates_uniqueness_of is horribly inefficient in mysql was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 10:13 PM

    +1 on feature, although not exactly fits into the current boolean convention, it's a well required addition, i would not scope it only for mysql, since FTS are ...

2481 Console/log output for malformed XML requests is not very helpful was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:54 PM

    2-3-stable patch applies cleanly, tests pass. Tested manually as well.

Monday, August 10 2009
3031 [PATCH] AS::JSON#decode does not parse xmlschema date strings to Time objects. was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 10:22 PM

    It crossed my mind that the first patch was not meant to apply on 2-3-stable, and it does apply on master cleanly with tests.

  • Elad Meidar
    Elad Meidar commented at 10:19 PM

    +1 verified, tests fail on 2-3-stable. -1 on patch, errors while attempting to apply.

    attached a working patch with passing tests for 2-3-stable

3029 [PATCH] Non JavaScript dependent record deletion solution was updated in Ruby on Rails
  • Elad Meidar
    • Tag changed from delete, destroy, javascript, rails, scafold to bugmash, delete, destroy, javascript, rails, scafold
    by Elad Meidar at 5:25 AM

    -1 i think it's better to leave it out, assuming that you add a delete method is somewhat not so RESTful imo. if there is a planned solution for a later version...

1760 in scaffold templates, change paragraph tags to fieldset tags was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:12 AM

    -1 particular patch. verified patch does not apply on 2-3-stable.

    Not sure that paragraphs are indeed the "semantic" way to arrange a form, but it's a basic gen...

2765 after_create callback not working as it should was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:57 AM

    I am totally mixed up, test SHOULD or SHOULDN'T be expected pass with the patch?

2582 [PATCH] ActionView::TextHelper Graceful Truncate was updated in Ruby on Rails
3028 ActiveSupport::Multibyte::Chars was updated in Ruby on Rails
  • Elad Meidar
    • Assigned user cleared.
    by Elad Meidar at 3:58 AM

    i was having a problem with the functionality using RTL languages as values, since rindex always scans left to right, strings were truncated in the wrong way.