This project is archived and is in readonly mode.
Allow i18n to be loaded from gem instead of from vendor dir
Allow i18n to be loaded from gem instead of from vendor dir. This way new versions of the I18n gem can be tested and used with rails.
Attached is a patch for the master branch (load_i18n_gem.diff) and one for the 2-3-stable branch (load_i18n_gem_23.diff).
-
load_i18n_gem.diff
946 Bytes
-
Lawrence Piterm.. sorry, don't use load_i18n_gem_23.diff, something went wrong, and the delete function for attachments in lighthouseapp doesn't work :(
-
Sven FuchsYep, thanks :)
-
Sven Fuchs
- Milestone changed from 2.x to 2.3.4
- Assigned user set to Pratik
Pratik, can you apply this? Makes it a bit easier for us to prove new stuff in the gem.
-
thedarkone+1, overwriting the included i18n lib is a pain :).
-
Repository
- State changed from new to resolved
(from [579250ea467ac406a5897dc2187c7959bf343b4f]) Use the i18n gem if present instead of vendor code. [#2871 state:resolved]
Signed-off-by: Yehuda Katz wycats@gmail.com
http://github.com/rails/rails/commit/579250ea467ac406a5897dc2187c79... -
Repository
(from [29c59858492d44cc737e1f0b944a51fe867261f8]) Use the i18n gem if present instead of vendor code. [#2871 state:resolved]
Signed-off-by: Yehuda Katz wycats@gmail.com
http://github.com/rails/rails/commit/29c59858492d44cc737e1f0b944a51... -
Sven Fuchs
Thanks, Yehuda :)
-
Sven Fuchs
- Assigned user changed from Pratik to Yehuda Katz (wycats)
- State changed from resolved to open
Apparently this doesn't work as intended: http://github.com/rails/rails/commit/29c59858492d44cc737e1f0b944a51...
The require statement needs to happen after the begin/rescue block because the gem statement does not require itself.
Also, I'd like to relax the pessimistic requirement ~> 0.1.3 to an optimistic requirement >= 0.1.3
Attached patch does this.
I'll reopen the ticket and assign to Yehuda.
Sorry for the hassle, obviously I should have looked at the original patch more closely.
-
Sven Fuchs
What? Lighthouse seems to break the file attachment? I'm getting a message "NoSuchKeyThe specified key does not exist.assets/afd88dd4ee91d5fb19befc1f1d8abaaf1d6aa266/0001-relax-gem-version-requirement-for-I18n-gem.patch753AB4FCB73DAB19WMtn3rcpWNeD0rc4jDSziVWLM/GmnmYtniW4coQ6WBsrPjlHNfASe0A95Ghlof6B" instead of the file I uploaded.
Here's a gist with the same patch: http://gist.github.com/145652
-
Sven Fuchs
Patch is there. Can someone apply this? Thanks :)
-
-
-
-
-
-
-
Santiago Pastorino
- Tag changed from 2-3-stable, 3.0, bugmash, patch to 2-3-stable, 30, bugmash, patch
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale