This project is archived and is in readonly mode.
Remove default_url_options from mailer generator. Improve mailer docs
Reported by Cody Fauser | April 21st, 2008 @ 03:13 PM
This patch removes the use of default_url_options from generated mailers and improves the documentation about URL generation with ActionMailer.
See #20 for more details.
Comments and changes to this ticket
-
Mislav April 21st, 2008 @ 04:01 PM
+1
I would only change the test so it tests that "default_url_options" isn't present in generated mailer. Little explicitness, prevents contributors to make same mistake I did.
-
Cody Fauser April 21st, 2008 @ 04:32 PM
Added an assert_no_match to the generator test with explanation as Mislav suggested.
-
josh April 21st, 2008 @ 08:33 PM
- Assigned user set to “josh”
- State changed from “new” to “resolved”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Cody Fauser
Mislav
Attachments
Tags
Referenced by
-
20
improve mailer generator and add tests
Please take a look at #32. I created a patch which updat...