Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] ERB in environment.rb after running rake dev

#3268

Running rake dev leaves ERB in environment.rb. The existing Rake task was just copying the file across. This patch modifies the Rake task to use the same ERB processing string used on database.yml, which cleans up the environment.rb file.

Reported by Blue Box Jesse · September 26th, 2009 @ 10:07 PM

State: resolved
Milestone: none
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: none

Activity

  1. Blue Box Jesse
    Blue Box Jesse
    • Title changed from ERD in environment.rb after running rake dev to ERB in environment.rb after running rake dev

    September 26th, 2009 @ 10:08 PM

  2. rbxbx
    rbxbx

    +1, patch applies cleanly and fixes the bug.

    September 26th, 2009 @ 10:33 PM

  3. Blue Box Jesse
    Blue Box Jesse

    Uploading revised patch in the proper patching format. :)

    September 26th, 2009 @ 10:56 PM

  4. John Trupiano
    John Trupiano

    verified the issue
    +1, the patch applies cleanly and fixes the bug.

    September 26th, 2009 @ 11:01 PM

  5. Blue Box Jesse
    Blue Box Jesse
    • Tag changed from bugmash to bugmash, patch
    • Title changed from ERB in environment.rb after running rake dev to [PATCH] ERB in environment.rb after running rake dev

    September 27th, 2009 @ 02:24 AM

  6. sr.iniv.t
    sr.iniv.t

    +1 verified.

    Confirming the issue exists on 2-3-stable - I ran into the issue trying to verify one of the bugs. The patch applies cleanly and things work as expected after patching.

    September 27th, 2009 @ 07:33 AM

  7. Akira Matsuda
  8. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from bugmash, patch to bugmash, bugmash-review, patch

    September 27th, 2009 @ 11:29 AM

  9. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from bugmash, bugmash-review, patch to bugmash-review, patch

    September 27th, 2009 @ 12:13 PM

  10. Matías Flores
    Matías Flores

    verified the issue on 2-3-stable
    +1 the patch applied cleanly and fixed it. Thanks.

    September 27th, 2009 @ 04:56 PM

  11. Michael Koziarski
    Michael Koziarski
    • Assigned user set to Yehuda Katz (wycats)

    September 28th, 2009 @ 02:45 AM

  12. John Trupiano
    John Trupiano

    Can we push this patch through? Without it "rake dev" is broken.

    September 29th, 2009 @ 12:58 PM

  13. Michael Koziarski
    Michael Koziarski
    • State changed from new to resolved

    October 6th, 2009 @ 08:46 PM

  14. John Trupiano
  15. Rizwan Reza
    Rizwan Reza
    • Tag changed from bugmash-review, patch to patch

    May 15th, 2010 @ 06:42 PM