Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Matías Flores

Matías Flores

Not a member

Matías Flores's latest activity

Monday, September 28 2009
3263 Failing functional test of a named route was updated in Ruby on Rails
  • Matías Flores
    Matías Flores commented at 5:13 AM

    I verified the behavior you described on 2-3-stable, but I'm not sure this is a bug.
    I agree with Gaius, correct syntax is :conditions => {:method => :get}, not...
3192 should be able to truncate a multibyte string to a max # of bytes was updated in Ruby on Rails
  • Matías Flores
    Matías Flores commented at 4:50 AM

    +1 verified Elad's patch applies cleanly on both master and 2-3-stable and all tests pass.
3291 [PATCH] ActiveSupport time extension tests failing depending on the local tim... was updated in Ruby on Rails
  • Matías Flores
    Matías Flores commented at 4:20 AM

    This is a duplicate of #3292 and should be deleted, sorry.
  • Matías Flores
    Matías Flores created the ticket at 4:12 AM

    There are two tests that are currently failing in both master and 2-3-stable if Feb 21st 2039 is considered DST on your local time zone.

    The problem is that Dat...
3292 ActiveSupport has broken tests depending on the local time zone was created in Ruby on Rails
  • Matías Flores
    Matías Flores created the ticket at 4:12 AM

    There are two tests that are currently failing in both master and 2-3-stable if Feb 21st 2039 is considered DST on your local time zone.

    The problem is that Dat...
Sunday, September 27 2009
3280 Prefer tap over returning in ActionMailer was updated in Ruby on Rails
  • Matías Flores
    Matías Flores commented at 10:15 PM

    Ok. I have created a new ticket with a separate patch for ActiveSupport at https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...
  • Matías Flores
    Matías Flores commented at 9:07 PM

    Yes, I wasn't sure if we'd need one patch for each lib or a single one that updates actionmailer, activesupport, etc. Should I change the patch? Add more patche...
  • Matías Flores
    Matías Flores created the ticket at 8:29 PM

    ActiveSupport's returning function has been replaced by object#tap whenever was possible.

    I've attached a patch to start using tap in the only place in ActionMa...
3281 Prefer tap over returning in ActiveSupport was created in Ruby on Rails
  • Matías Flores
    Matías Flores created the ticket at 10:14 PM

    ActiveSupport's returning function has been replaced by object#tap whenever was possible.

    I've attached a patch to start using tap in those areas of ActiveSuppo...
2878 image_tag doesn't allow :escape => false option anymore was updated in Ruby on Rails
  • Matías Flores
    Matías Flores commented at 7:57 PM

    verified the wrong behavior in both master and 2-3-stable
    +1 both patches applies cleanly and fix the issue