This project is archived and is in readonly mode.
[patch] image_tag doesn't allow :escape => false option anymore
-
mdeering- Tag set to actionview, bugmash, image_tag
I just ran into this. This seems pretty clear cut to fix.
tag parameters
tag(name, options = nil, open = false, escape = true)
But when called from image_tag is just called like so
tag("img", options)
Should be able to change the call inside of image_tag over to?
tag("img", options, false, options.delete(:escape))
I have never contributed to Rails so give me some time to poke around find the procedures.
-
mdeering
Attaching the patch to fix/allow the escape option to work with image_tag
-
mdeering
- Tag changed from actionview, bugmash, image_tag to actionview, bugmash, image_tag, patch
Adding the patch tag as per the contributers guide.
-
Elad Meidar-1 Patch did not apply on 2-3-stable.
-
mdeering
Patch was against Edge Rails. I will do one up quickly for 2-3-stable if that is what is needed.
-
Elad Meidar
And here is a patch that applies for 2-3-stable
-
Elad Meidar
i am pretty sure you need to patch both... but there you have it anyway..
-
Matías Floresverified the wrong behavior in both master and 2-3-stable
+1 both patches applies cleanly and fix the issue -
mdeering
- Title changed from image_tag doesn't allow :escape => false option anymore to [patch] image_tag doesn't allow :escape => false option anymore
Adding patch to the title. Really not sure what else is needed to get movement or feedback. Tried to posting to IRC a few times with no luck.
-
Elad Meidar
Maybe a "review" tag is going to help, but i am not sure.
-
Rizwan Reza- Tag changed from actionview, bugmash, image_tag, patch to actionview, image_tag, patch
-
-
Rizwan Reza
- Tag changed from actionview, image_tag, patch to actionview, bugmash, image_tag, patch
- State changed from new to open
Do we still need this?
-
Neeraj SinghThis is not an issue with rails3.
Just specify :alt => nil and image tag will not have 'alt' attribute.
-
Rizwan Reza
- Tag changed from actionview, bugmash, image_tag, patch to actionview, image_tag, patch
- State changed from open to resolved
-
tsailipu
HI, Neeraj and Rizwan, how is this Neeraj's response related to the :escape => false option that this bug is about?
-
tsailipu
- Assigned user set to Rizwan Reza
-
Neeraj Singh
@tsailipu I misread the question. The question was about escaping of attributes and I got it wrong. Sorry about that.
