#2878 [patch] image_tag doesn't allow :escape => false option anymore - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2878 ✓resolved

[patch] image_tag doesn't allow :escape => false option anymore

Reported by tsailipu | July 6th, 2009 @ 10:32 PM | in 3.x

image_tag used to allow the caller to specify :escape => false option to avoid escaping its attribute values. The current implementation simply invokes tag() without honoring the :escape option anymore.

Comments and changes to this ticket

You flagged this item as spam.
mdeering September 24th, 2009 @ 05:44 AM
- Tag set to “actionview, bugmash, image_tag”
I just ran into this. This seems pretty clear cut to fix.

tag parameters

tag(name, options = nil, open = false, escape = true)

But when called from image_tag is just called like so

tag("img", options)

Should be able to change the call inside of image_tag over to?

tag("img", options, false, options.delete(:escape))

I have never contributed to Rails so give me some time to poke around find the procedures.
You flagged this item as spam.
mdeering September 24th, 2009 @ 07:13 AM
Attaching the patch to fix/allow the escape option to work with image_tag
- image-tag-allow-escape-option.diff 3.6 KB
You flagged this item as spam.
mdeering September 24th, 2009 @ 07:36 AM
- Tag changed from “actionview, bugmash, image_tag” to “actionview, bugmash, image_tag, patch”
Adding the patch tag as per the contributers guide.
You flagged this item as spam.
Elad Meidar September 25th, 2009 @ 06:15 AM
-1 Patch did not apply on 2-3-stable.
You flagged this item as spam.
mdeering September 25th, 2009 @ 06:23 AM
Patch was against Edge Rails. I will do one up quickly for 2-3-stable if that is what is needed.
You flagged this item as spam.
Elad Meidar September 25th, 2009 @ 06:28 AM
And here is a patch that applies for 2-3-stable
- 2878-image_tag_escape_option_2-3-stable.diff 3.1 KB
You flagged this item as spam.
Elad Meidar September 25th, 2009 @ 06:36 AM
i am pretty sure you need to patch both... but there you have it anyway..
You flagged this item as spam.
Matías Flores September 27th, 2009 @ 07:57 PM
verified the wrong behavior in both master and 2-3-stable
+1 both patches applies cleanly and fix the issue
You flagged this item as spam.
mdeering October 1st, 2009 @ 05:30 AM
- Title changed from “image_tag doesn't allow :escape => false option anymore” to “[patch] image_tag doesn't allow :escape => false option anymore”
Adding patch to the title. Really not sure what else is needed to get movement or feedback. Tried to posting to IRC a few times with no luck.
You flagged this item as spam.
Elad Meidar October 1st, 2009 @ 05:41 AM
Maybe a "review" tag is going to help, but i am not sure.
Rizwan Reza February 12th, 2010 @ 12:46 PM
- Tag changed from “actionview, bugmash, image_tag, patch” to “actionview, image_tag, patch”
[bulk edit]
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Rizwan Reza May 16th, 2010 @ 03:54 AM
- Tag changed from “actionview, image_tag, patch” to “actionview, bugmash, image_tag, patch”
- State changed from “new” to “open”
Do we still need this?
Neeraj Singh May 16th, 2010 @ 04:20 AM
This is not an issue with rails3.

Just specify :alt => nil and image tag will not have 'alt' attribute.
Rizwan Reza May 16th, 2010 @ 04:12 PM
- Tag changed from “actionview, bugmash, image_tag, patch” to “actionview, image_tag, patch”
- State changed from “open” to “resolved”
You flagged this item as spam.
tsailipu May 16th, 2010 @ 06:25 PM
HI, Neeraj and Rizwan, how is this Neeraj's response related to the :escape => false option that this bug is about?
You flagged this item as spam.
tsailipu May 16th, 2010 @ 06:30 PM
- Assigned user set to “Rizwan Reza”
Neeraj Singh May 16th, 2010 @ 08:03 PM
@tsailipu I misread the question. The question was about escaping of attributes and I got it wrong. Sorry about that.