This project is archived and is in readonly mode.
[PATCH] Prefer tap over returning in ActiveSupport
Reported by Matías Flores | September 27th, 2009 @ 10:14 PM
ActiveSupport's returning function has been replaced by object#tap whenever was possible.
I've attached a patch to start using tap in those areas of ActiveSupport that were still using returning.
Notice that there are two different patches, one for master and the other for 2-3-stable.
Comments and changes to this ticket
-
-
Gaius Centus Novus September 28th, 2009 @ 12:00 AM
- Tag changed from “activesupport, bugmash, patch” to “2-3-stable, activesupport, bugmash, patch”
- Title changed from “Prefer tap over returning in ActiveSupport” to “[PATCH] Prefer tap over returning in ActiveSupport”
-
Rizwan Reza February 12th, 2010 @ 12:46 PM
- Tag changed from “2-3-stable, activesupport, bugmash, patch” to “2-3-stable, activesupport, patch”
-
Rohit Arondekar July 1st, 2010 @ 10:27 AM
- State changed from “new” to “stale”
- Importance changed from “” to “”
The file this patch was provided for has changed considerably.
Master: http://github.com/smtlaissezfaire/rails/blob/2d233ebdcf0de9e769da52...
2-3-stable: http://github.com/smtlaissezfaire/rails/blob/2-3-stable/activesuppo...
Closing ticket as stale. Matias, if this is still an issue please make a comment to reopen and I'll oblige.
-
-
Ryan Bigg October 14th, 2010 @ 01:55 AM
- State changed from “stale” to “resolved”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
Matías Flores
Rohit Arondekar
Ryan Bigg
Attachments
Referenced by
-
3283
[PATCH] Prefer tap to returning in ActionPack
Along the lines of #3280 and #3281, but for ActionPack. P...
-
3284
[PATCH] Prefer tap to returning in ActiveRecord
Along the lines of #3280, #3281, and #3283, but
for Actio...
-
3285
[PATCH] Prefer tap to returning in Railties
Like #3280, #3281, #3283,
#3284, but for Railties. Tested...