Failing functional test of a named route

Giuseppe, can you please specify the rails version you're on?

Seems to work for me on 2.3.3:

ts > rails -v
Rails 2.3.3

ts > cat config/routes.rb 
ActionController::Routing::Routes.draw do |map|
  map.accept_invitation '/accept_invitation/:id', :controller => "invitations", :action => "accept", :method => "get"
  map.connect ':controller/:action/:id'
end

ts > cat app/controllers/invitations_controller.rb 
class InvitationsController < ApplicationController
  def accept; end
end

ts > cat test/functional/invitations_controller_test.rb 
require 'test_helper'

class InvitationsControllerTest < ActionController::TestCase
  test "the post accept invitation should be successful" do
    get :accept, :id => "1"
    assert_response :success
  end
end

ts > ruby -Itest test/functional/invitations_controller_test.rb 
Loaded suite test/functional/invitations_controller_test
Started
.
Finished in 0.082477 seconds.

1 tests, 1 assertions, 0 failures, 0 errors

Hi, I am on rails 2.3.4.

I believe that the reason your test passes is that, after the named route in question, you have the catch-all route (:controller/:action/:id). What happens if you remove the latter?

Cheers,
Giuseppe

verified, when removing the default routes this error does indeed occur.

It's noteworthy that removing :method => 'get' from the route eliminates the problem.

+1 verified.

it might have something to do with the use of accept as a method name? maybe get :accept is confusing for some reason...

No it's not.... i tried a different action name and it still failed... possibly this has something to do with the catch-all route that may be required.

Does the view app/views/invitations/accept.html.erb exist? Your empty definition of accept implicitly renders this view (or the more general app/views/inivitations/accept.erb). If that doesn't exist, you'll get a 404.

Also, you don't mean :method => :get, you mean :conditions => { :method => :get }.

I verified the behavior you described on 2-3-stable, but I'm not sure this is a bug.
I agree with Gaius, correct syntax is :conditions => {:method => :get}, not just :method => 'get'

Suppose you have the following two named routes (along with controller actions and .erb templates):

ActionController::Routing::Routes.draw do |map|
  map.accept_invitation '/accept_invitation/:id', :controller => "invitations", :action => "accept", :conditions => {:method => "get"}
  map.view_invitation '/view_invitation/:id',   :controller => "invitations", :action => "view",   :method => "get"
end

and the following two test:

test "the get accept invitation should be successful" do
  get :accept, :id => "1"
  assert_response :success
end
test "the get view invitation should be successful" do
  get :view, :id => "1"
  assert_response :success
end

The first passes, while the second returns an error, seemingly supporting Gaius and Matías.
However, if you stick the following 2 URLs in your browser:

http://localhost:3000/accept_invitation/1
http://localhost:3000/view_invitation/1

...then the FORMER request fails, while the latter succeeds.

Which leads to the following proposal.

• The testing framework simply enforces the proper :conditions => {:method => :get} syntax, so there's no problem there.
• It's really the routing that behaves funny.

Reasonable?

I have run into the same problem with restful routes. Something as simple as the following will fail in testing.

routes.rb
map.resources :products

products_controller_test.rb
test "should get index" do
  get :index
  assert_response :success
end

Whatever format the testing framework requires you would think that the generated routes will be correct. This must be a bug, surely resource routes are meant to be testable in functional tests.