Prem Sichanugrist (sikachu)
Member of 1 project: Ruby on Rails
Prem Sichanugrist (sikachu)'s latest activity
Wednesday, April 27 2011
-
- State changed from stale to committed
Actually, this ticket should be marked as committed. I forgot >_<
This ticket related to this pull request: https://github.com/rails/rails/pull/258
Wednesday, March 23 2011
-
Prem Sichanugrist (sikachu) commented at 11:30 AMBy the way, I'm backing of on pulling those two Aaron's patch back, as I don't think user would expect that on a stable branch. I don't think I want to break so...
-
Prem Sichanugrist (sikachu) commented at 11:04 AMIf it's a simple fix, then I'm totally agree with you. Are you going to fix that in Rack::Mount for me, or do you want me to send pull request in?
Anyhow, here'...
-
- State changed from resolved to verified
@Andrew White: but then the RegExp actually has to be fixed in Rack::Mount, right?
Tuesday, March 22 2011
-
Prem Sichanugrist (sikachu) commented at 3:36 PMThis is a patch for
master.I'm still working on the patch for
3-0-stable, as my patch is currently rely on these two commits: https://github.com/rails/rails/co... -
Prem Sichanugrist (sikachu) created the ticket at 3:19 PMCurrently in Rails, when you're adding a wildcard route and run
rake routes, you'll usually see an entry like thisroutes.rb
match '/*path', :to => 'pages#show...
Friday, March 11 2011
-
Prem Sichanugrist (sikachu) commented at 2:09 AMThank you for updating my patch and push them for me. ;)
Jeez, seems like I keep overlooking something.
Wednesday, March 09 2011
-
- Assigned user changed from Prem Sichanugrist (sikachu) to Xavier Noria
I've update the patch to fixes those issues above, and add those cases as the test.
I've included patch for
masterand3-0-stable. The only difference is the CH...
Friday, February 25 2011
Thursday, February 24 2011
-
- Assigned user changed from José Valim to Aaron Patterson
I've updated the patch and rebase 002+003 together, per Aaron request