This project is archived and is in readonly mode.

#3291 ✓stale
Matías Flores

[PATCH] ActiveSupport time extension tests failing depending on the local time zone

Reported by Matías Flores | September 28th, 2009 @ 04:06 AM

There are two tests that are currently failing in both master and 2-3-stable if Feb 21st 2039 is considered DST on your local time zone.

The problem is that DateTime.local_offset is used to calculate one of the local times, and Time.local is used to create the other. As DateTimes are not aware of any DST rules, the resulting times have a difference of one hour and therefore the tests fail.

I've attached a patch that fixes the broken tests by forcing the time zone to US/Eastern for these tests. The patch applies cleanly to both master and 2-3-stable.

As we're not specifically testing DST calculation in any of these tests, I think there's no need to duplicate the tests using the NZ (or any other) time zone. If you think this is needed I will adjust the patch accordingly.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket