This project is archived and is in readonly mode.

#3593 ✓ stale
johno

[PATCH] Support for highlighting with ignoring special chars.

Reported by johno | December 17th, 2009 @ 02:40 PM

Hi!

I've created a patch for TextHelper::highlight that adds an option :ignore_special_chars, usable for highlighting strings that contain special characters with queries without special characters and vice-versa.

Example:

    highlight('Šťabajzna', 'stabajzna', :ignore_special_chars => true)
    # => <strong class="highlight">Šťabajzna</strong>

BTW don't know why but:

    haystack = ActiveSupport::Multibyte::Chars.new(haystack).normalize(:kd)
    haystack = haystack.mb_chars.normalize(:kd) # not working on Windows without $KCODE = 'u'

Comments and changes to this ticket

  • Michal Hantl
  • Vojto

    Vojto January 4th, 2010 @ 12:25 PM

    Very useful for non-english speaking countries.

  • johno

    johno May 14th, 2010 @ 03:51 PM

    For anyone wondering about what is this good for.

    It ignores special characters like national alphabets when highlighting strings. (e.g. Štabajzna would also highlight stabajzna.)

    Normally users search without using special characters with accents, umlauts... but when you try to highlight matches in search results with current implementation of highlight you are out of luck.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Tickets have moved to Github

The new ticket tracker is available at https://github.com/rails/rails/issues

Shared Ticket Bins

People watching this ticket

Attachments

Pages