helper :all on by default

I'm working on a patch for this one.

I think I need to clarify.

I was using the first Rails 3.0 Beta for a project, the weekend it was released. I'm not sure why the timestamp for this issue says Apr 13th. According to my project commits, this issue came up Feb 13th, 2010 and I had thought I submitted the issue then. I've already worked around this and finished the project so I am fuzzy on the details. I have:

class Admin::FeaturesController < ActionController

# ...

end

class Manage::FeaturesController < ActionController

# ...

end

module Admin::FeaturesHelper

def render_edit_features(lender)
  render :partial => 'admin/features/edit_features', :locals => { :lender => lender }                                                                                        
end

end

module Manage::FeaturesHelper

def render_edit_features(lender)
  render :partial => 'manage/features/edit_features', :locals => { :lender => lender }                                                                                        
end

end

Since I did not have

class ApplicationController < ActionController::Base

helpers :all

end

but rather something like

class ApplicationController < ActionController::Base

#helpers :all

end

I was expecting Rails 2 behavior where Admin::FeaturesController loads only Admin::FeaturesHelper but not Manage::FeaturesHelper. This was not the case, and the methods stepped on each other. I worked around this by renaming Manage::FeaturesHelper#render_edit_features to Manage::FeaturesHelper#render_edit_manage_features and moved on.

I have no idea if this got caught and fixed in the second beta release. I'm certainly not asking for the ability to turn off all helpers, but I'm glad that got brought up. I'm working on a web services project that has no view layer and no helper layer, so down the road, I may want turn off all helpers ... but it isn't really critical. My original issue has to do with the helpers :all declaration.

Messed up the formatting. Here are the codeblocks again:

class Admin::FeaturesController < ActionController
  # ...
end

class Manage::FeaturesController < ActionController
  # ...
end

module Admin::FeaturesHelper
  def render_edit_features(lender)
    render :partial => 'admin/features/edit_features', :locals => { :lender => lender }                                                                                        
  end
end

module Manage::FeaturesHelper
  def render_edit_features(lender)
    render :partial => 'manage/features/edit_features', :locals => { :lender => lender }                                                                                        
  end
end

I'm in the same boat as Ho-Sheng Hsiao.

I tend to use generic method names in views such as destroy_link_for(object) or format_date(date) and specify the exact desired behaviour in the appropriate controller's helper.

If I want to make a method globally available, I put in in application_helper.rb

Combing through all my helpers, ensuring that I'm not reusing a method name each time... is not fun, and could lead to all kinds of entertaining bugs.

Not being able to use nice generic intent-descriptive methods in views is rather ugly too, IMHO.

A config option to turn off the auto-all feature would be highly appreciated.

Bump. Just ran into this today.

Mixing in all helpers into every renderer pretty much defeats the purpose of having per-controller helpers. With the current behavior, you may as well just put everything in ApplicationHelper.

@jbc, @Mat since this ticket got marked invalid for some reason, I think we're better off coming up with a patch.

Sure would. I put it on my list of things to try to fix. But in the meantime:

@yehuda: is there some reason for this behavior? Performance maybe?

+1 for me. I'm having the same issue with an admin interface that uses the same method names as the public interface but require different outputs.

+1, the solution in Rails 2 was much more elegant and made sense (if you want it, we got it, if you don't, comment it out). Yehuda's solution looks very Java-esk and extremely confusing... what is the "*" for?!? Does anyone comprehend that code by just reading over it? Probably not without a serious double-take. DHH's original design for inclusion of all helpers seemed to be fine to me.

I have added #4750 Add feature, turning off autoloading helpers with a proposal for the configuration flags to fix this.

louis vuitton watches

very nice pictures is also very lively and attractive you look .every one who wanted to congratulate you You look super. Ankara nakliyat A wonderful picture,nakliyat ankara and always such a special and very attractive as well stay beautiful ok Ankara evden eve nakliyat Ankara nakliye