Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

browser compatibility changes for prototype-ujs

#4133

The attached patch works around the following problems in the prototype rails.js:

  • Element.findElement("a[data-remote]") etc. didn't work in Konqueror. It seems not to return; didn't investigate further. My workaround is to check whether the current element is a anchor and has data-xxx set. This makes more sense anyway, because I cannot think of a use case where we would take the url of a parent element instead of the one that triggered the click event.
  • The submit event doesn't bubble in IE (as was already noted in a comment). I've worked around this by observing the click event of the form's submit button instead (which is also fired when the button is pressed via keyboard).

Tested in FF 3.6, Konqueror 4.4.0, IE 8 (normal and in compat mode).

Reported by Marc Schütz · March 8th, 2010 @ 07:47 PM

State: invalid
Milestone: 3.0.2
Assigned to: josh josh
Importance: Low

Activity

  1. Marc Schütz
  2. Marc Schütz
    Marc Schütz

    Updated patch to make link_to with images work, as suggested by Robs in #4156 link_to doesn't behave when using image_tag and :confirm or :remote.

    March 12th, 2010 @ 10:21 AM

  3. Marc Schütz
    Marc Schütz

    As regards Konquerors inability to cope with Element.findElement("xxx"), it doesn't work in Konqueror 3.5.9, but it does work in Konqueror 4.4.1. So I removed the changes for Konqueror again.

    New patches tested in FF 3.6, Konqueror 4.4.1, IE 6 and IE 8 (normal and compat).

    March 12th, 2010 @ 11:33 AM

  4. Jeremy Kemper
    Jeremy Kemper
    • State changed from new to open
    • Assigned user set to josh
    • Milestone cleared.

    March 12th, 2010 @ 06:33 PM

  5. josh
    josh
    • State changed from open to invalid

    The new css selector stuff requires edge prototype.

    March 12th, 2010 @ 06:40 PM

  6. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM