This project is archived and is in readonly mode.
ActionPack tests have errors and failures
Reported by Rohit Arondekar | May 16th, 2010 @ 08:33 AM
ActionPack in Rails master has 3 errors and 2 failures in the test suite. Ran on ruby 1.9.2dev (2010-05-08 trunk 27665) [x86_64-linux]
I have fixed 3 errors and 1 failure and will submit a patch after I get a ticket nos. The remaining failure(nos 5 in the trace) has something to do with #4559 I believe, https://rails.lighthouseapp.com/projects/8994/tickets/4559 (Thanks to wijnand_ from #railsbridge for pointing out that ticket).
Stack trace (or pastie => http://pastie.org/962333 ):
P.S I have removed the dots here since it occupies a lot of
space)
1) Failure: test_assert_select_text_match(AssertSelectTest)
[test/controller/assert_select_test.rb:210]:
Exception raised:
<#<ArgumentError: assertion message must be String or Proc,
but Hash was given.>>.
2) Error: test_css_select(AssertSelectTest):
ArgumentError: assertion message must be String or Proc, but Fixnum
was given.
test/controller/assert_select_test.rb:279:in `test_css_select'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'
3) Error:
test_with_output_buffer_sets_proper_encoding(CaptureHelperTest):
ArgumentError: assertion message must be String or Proc, but
Encoding was given.
test/template/capture_helper_test.rb:77:in `block in test_with_output_buffer_sets_proper_encoding'
/home/rohit/remote-repos/rails/actionpack/lib/action_view/helpers/capture_helper.rb:150:in `with_output_buffer'
test/template/capture_helper_test.rb:76:in `test_with_output_buffer_sets_proper_encoding'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'
4) Error:
test_render_against_etag_request_should_have_no_content_length_when_match(EtagRenderTest):
ArgumentError: assertion message must be String or Proc, but
NilClass was given.
test/controller/render_test.rb:1391:in `test_render_against_etag_request_should_have_no_content_length_when_match'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'
5) Failure: test_nil_id(FormHelperTest)
[test/template/form_helper_test.rb:452]:
<" expected to be == to
<"..
Expected block to return true value.
2678 tests, 11309 assertions, 2 failures, 3 errors, 0 skips
Comments and changes to this ticket
-
Rohit Arondekar May 16th, 2010 @ 08:40 AM
- Tag set to actionpack rails3, tests actionpack, bugmash-patch
-
Rohit Arondekar May 16th, 2010 @ 08:41 AM
- Tag changed from actionpack rails3, tests actionpack, bugmash-patch to actionpack rails3, tests actionpack, bugmash
Sorry for the bad tagging. :(
-
Hussein Morsy May 16th, 2010 @ 01:16 PM
Rohit has fixed 1 failure und 3 Errors. A fix for one failure is still missing.
I have patch which includes 2 commits (one from Rohit and one from me):- Fixed 1 failure and 3 errors in ActionPack testsuite [#4613 state:commited]
- fixed 1 failure in ActionPack testsuite [#4613 state:resolved]
all test in ActionPack are working in ruby 1.8.7 and ruby 1.9.2
-
Repository May 16th, 2010 @ 01:35 PM
(from [fc2480a277fd4753aebf68dcf8787d24e00bd057]) Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/fc2480a277fd4753aebf68dcf8787d... -
Repository May 16th, 2010 @ 02:03 PM
- State changed from open to resolved
(from [4ea48f2a9880508a4967be011345fc05570f44c4]) Fixed 1 failure in ActionPack testsuite [#4613 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/4ea48f2a9880508a4967be011345fc... -
Rizwan Reza May 16th, 2010 @ 03:04 PM
- Tag changed from actionpack rails3, tests actionpack, bugmash to actionpack rails3, tests actionpack
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 4613 ActionPack tests have errors and failures Fixed 1 failure and 3 errors in ActionPack testsuite [#46...
- 4613 ActionPack tests have errors and failures fixed 1 failure in ActionPack testsuite [#4613 state:reso...
- 4613 ActionPack tests have errors and failures (from [fc2480a277fd4753aebf68dcf8787d24e00bd057]) Fixed 1...
- 4613 ActionPack tests have errors and failures (from [4ea48f2a9880508a4967be011345fc05570f44c4]) Fixed 1...