Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Executable bit on some files

#4802

This does not affect code working but ugly and confuses shell users.
Executable permission bit is set for some files which are not expected to be run.

$ find acti* rail* -type f -perm /111 -exec ls -F '{}' +
actionpack-3.0.0.beta4/lib/action_dispatch/http/request.rb*
activerecord-3.0.0.beta4/examples/performance.rb*
activerecord-3.0.0.beta4/lib/active_record/associations.rb*
activerecord-3.0.0.beta4/lib/active_record/base.rb*
activerecord-3.0.0.beta4/lib/active_record/connection_adapters/abstract_adapter.rb*
activesupport-3.0.0.beta4/lib/active_support/core_ext/object/to_param.rb*
[This is OK->] rails-3.0.0.beta4/bin/rails*
railties-3.0.0.beta4/guides/assets/javascripts/code_highlighter.js*
railties-3.0.0.beta4/guides/assets/javascripts/guides.js*
railties-3.0.0.beta4/guides/assets/stylesheets/print.css*
railties-3.0.0.beta4/guides/assets/stylesheets/reset.css*
railties-3.0.0.beta4/guides/assets/stylesheets/style.css*
railties-3.0.0.beta4/lib/rails/commands/generate.rb*
railties-3.0.0.beta4/lib/rails/generators/rails/app/templates/Rakefile*

Reported by Sakuro · June 9th, 2010 @ 03:28 AM

State: resolved
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to open
    • Assigned user set to José Valim

    This is still the case in Rails master.

    I've attached a patch that fixes this.

    June 16th, 2010 @ 02:23 PM

  2. Repository
    Repository
    • State changed from open to resolved

    (from [95a8f252c028c94b70cce4888bce42b7e9e30786]) remove executable permission from files that don't need it. [#4802 Executable bit on some files state:resolved]

    Signed-off-by: José Valim jose.valim@gmail.com
    http://github.com/rails/rails/commit/95a8f252c028c94b70cce4888bce42...

    June 19th, 2010 @ 11:59 PM