Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Clean up the list of excluded ivars that get added to assigns in a view test case

#4930

ActionView::TestCase copies instance variables from the test case to view in the _assigns method. It excludes ivars that are set up and used by the test case, but the list of ivars currently includes a number of variables that are outdated (no longer exist) and excludes some new variables.

Patch forthcoming to clean that up.

Reported by David Chelimsky · June 22nd, 2010 @ 03:58 PM

State: resolved
Milestone: none
Assigned to: José Valim José Valim
Importance: none

Activity

  1. David Chelimsky
    David Chelimsky
    • Assigned user set to José Valim

    Patch: http://github.com/dchelimsky/rails/commit/7378fa34be0b5c6945ae8f407...

    Note that I didn't add any tests for this. Doing so would create a binding between the tests (they'd have to name all the ivars explicitly) and the implementation. The only risk is that somebody wants to use an instance variable name that is used internally by test case, which is a deeper design question than the specific contents of this list.

    June 22nd, 2010 @ 04:02 PM

  2. Repository
    Repository
    • State changed from new to resolved

    June 22nd, 2010 @ 04:16 PM