This project is archived and is in readonly mode.
[PATCH] Warnings about shadowing vars in AR
Reported by Łukasz Strzałkowski | July 15th, 2010 @ 07:08 PM
While investigating some bug in AR I saw that there's a lot of noise when running AR tests. I've corrected code which caused warnings about shadowed vars.
Here's a patch: http://github.com/strzalek/rails/commit/a7d0cbd46bbaacaaf57f3d4944a...
Comments and changes to this ticket
-
Łukasz Strzałkowski July 16th, 2010 @ 08:24 PM
Removed some more warnings:
http://github.com/strzalek/rails/commit/cc5eb4a4c72d18fdcdfaa2b1ca5...
-
Łukasz Strzałkowski July 19th, 2010 @ 09:28 AM
- Assigned user set to “Aaron Patterson”
I've made some more changes, also removing redefining method warnings
http://github.com/strzalek/rails/compare/rails:master...master
(commit about before_type_cast is connected to ticket #3973)Assigning to Aaron as he is the most active in ActiveRecord recently.
-
Aaron Patterson July 19th, 2010 @ 04:48 PM
- State changed from “new” to “committed”
- Importance changed from “” to “Low”
Tests pass, and the changes look good to me. I've merged everything to master.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Aaron Patterson
Jeremy Kemper
Łukasz Strzałkowski