Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Warnings about shadowing vars in AR

#5126

While investigating some bug in AR I saw that there's a lot of noise when running AR tests. I've corrected code which caused warnings about shadowed vars.

Here's a patch: http://github.com/strzalek/rails/commit/a7d0cbd46bbaacaaf57f3d4944a...

Reported by Łukasz Strzałkowski · July 15th, 2010 @ 07:08 PM

State: committed
Milestone: none
Assigned to: Aaron Patterson Aaron Patterson
Importance: Low

Activity

  1. Łukasz Strzałkowski
    Łukasz Strzałkowski

    July 16th, 2010 @ 08:24 PM

  2. Łukasz Strzałkowski
    Łukasz Strzałkowski
    • Assigned user set to Aaron Patterson

    I've made some more changes, also removing redefining method warnings

    http://github.com/strzalek/rails/compare/rails:master...master
    (commit about before_type_cast is connected to ticket #3973 before_type_cast not available for datetime fields)

    Assigning to Aaron as he is the most active in ActiveRecord recently.

    July 19th, 2010 @ 09:28 AM

  3. Aaron Patterson
    Aaron Patterson
    • State changed from new to committed
    • Importance changed from to Low

    Tests pass, and the changes look good to me. I've merged everything to master.

    July 19th, 2010 @ 04:48 PM