Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Various test case conditions for the SQLServerAdapter

#5333

A few test case conditions that would be nice to have in the 3.0 release.

Reported by Ken Collins · August 8th, 2010 @ 04:34 AM

State: committed
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Ken Collins
  2. Ken Collins
    Ken Collins

    I am going to continue to keep coerced test cases in the adapters code, however I do need this change (new patch attached) to the schema.rb so that it loads up correctly. We are using the same precision for atoms_in_universe as the Oracle adapter.

    August 8th, 2010 @ 11:11 PM

  3. Ken Collins
    Ken Collins

    Wow, another schema bug found. I found items.name was an :integer vs a :string data type which caused fixtures to blow up when running tests. Updated patch attached.

    August 9th, 2010 @ 02:53 AM

  4. Ken Collins
    Ken Collins

    I just noticed that others reported this issue in #4967 rake test fails in create_table :numeric_data on MS SQL Server but this ticket has tested patches.

    August 10th, 2010 @ 08:57 PM

  5. Henrik Hodne
    Henrik Hodne
    • Tag changed from 3.0, activerecord, sqlserver to 3.0, activerecord, patch, sqlserver

    August 11th, 2010 @ 01:15 AM

  6. kdgundermann
    kdgundermann

    +1 tested on Windows with SQLServer 2005 / 2008 Necessary, else some Rails tests will fail

    September 1st, 2010 @ 08:50 AM

  7. Michael Koziarski
    Michael Koziarski
    • State changed from new to committed
    • Importance changed from to Low

    The first one doesn't apply any longer, is it still required?

    Your later one has been applied to master and 3-0-stable.

    September 3rd, 2010 @ 03:59 AM

  8. Ken Collins
    Ken Collins

    Correct, the first file is no longer needed. We dynamically redefine the test cases needed for the adapter vs cluttering the rails test suite with our stuff. Allows us to cope with out own internal changes and DB versions more easily.

    Thanks for this and your commit on 5188!

    September 3rd, 2010 @ 04:08 AM