Ken Collins's profile

Ken Collins created the ticket at 4:17 PM
The v3.0.4 limit regression and security fix here [1] should allow for ARel's SQL literal values to pass thru sanitization intact. This patch just adds a few li...

Ken Collins commented at 9:35 PM
FYI, this test is below mine and is even visible in the patch. It outlines the nil question of yours.
```
def test_should_return_nil_as_average
  assert_nil Numeri...
```
Ken Collins commented at 9:12 PM
I had a test that directly tested the method but that it would have been discouraged. It looked something like this.
```
expected_value = 3
column = Account.column...
```
Ken Collins commented at 8:15 PM

OK, uploaded a new patch. Test added, used the respond_to? method. All tests passed in mysql/postgresql/sqlite.

Also, will this make it into the v3.0.4 release?
Ken Collins commented at 7:49 PM
Trying this right now. Just got to figure out the right stub point. For instance.
```
def test_should_return_integer_average_if_db_returns_such
  Account.connectio...
```
Ken Collins commented at 6:58 PM

Specifically SQL Server. Details on return type here.
http://msdn.microsoft.com/en-us/library/ms177677.aspx

Re the code style, I do like your line better and te...

Ken Collins created the ticket at 2:59 AM
Some databases return integer values for AVG. Allow that value to pass through vs raising an Fixnum#to_d no method error.

Ken Collins commented at 3:12 PM
Link to ticket #5887
https://rails.lighthouseapp.com/projects/8994/tickets/5887
Ken Collins commented at 3:12 PM
Can anyone run the tests for ActiveRecord under 1.9.2? I can not, and created ticket 5887. I verified that this patch does somewhat speed up my app's testing un...

Ken Collins commented at 2:39 PM
I neglected to mention this is 2-3-stable only.