Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ken Collins

Ken Collins

Software Engineer · Not a member

Ken Collins's latest activity

Tuesday, June 16 2009
2476 ASCII-8BIT encoding of query results in rails 2.3.2 and ruby 1.9.1 was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 7:57 PM

    Agreed. I do the same thing in the SQL Server adapter.
Tuesday, June 02 2009
2675 Support for multiparameter attribute assignment on virtual attribute writers was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 9:38 PM

    This bit us today too. The fallback to time is a real nice way to handle this IMHO.
Monday, May 18 2009
2633 Consistent Integer Values Using Fixtures.identify In Ruby1.9 was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 6:30 PM

    I'd consider this ready-to-go. Jeremy can you get it in?
Tuesday, May 12 2009
2060 Installation Of MiniUnit Causes Test To Fail was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 2:57 PM

    This can be marked invalid. It is moot under the release of 1.9.1 and rails 2.3.2.
2554 ActiveRecord::Base#sanitize_sql_hash_for_conditions & #sanitize_sql_hash_for_... was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 2:52 PM

    I just tried this patch on current master and it does pass all the tests in all three DBs. Can their be tests added for this? It might get acceptance quicker if...
2633 Consistent Integer Values Using Fixtures.identify In Ruby1.9 was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 4:23 AM

    Much cleaner! Passes all tests still on all DBs.
  • Ken Collins
    Ken Collins commented at 3:38 AM

    OK, this one passes all the DB tests, most importantly PostgreSQL.
  • Ken Collins
    Ken Collins commented at 1:41 AM

    I'd hold off on this one too... I'm having issue under the SQL Server adapter since the values might be too big there too.
  • Ken Collins
    Ken Collins commented at 12:28 AM

    OK, here is v2 of the patch. I'm using Zlib like Jeremy suggested. The only problem I ran into is that the default crc32 method could generate a bignum that is ...
Monday, May 11 2009
2633 Consistent Integer Values Using Fixtures.identify In Ruby1.9 was updated in Ruby on Rails
  • Ken Collins
    Ken Collins commented at 11:08 PM

    @Jeremy Could you give me an example of a crc value? I'm having a hard time thinking of how to get a consistent fixnum representation from a string.

    @Frederick ...