Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

add has_many test for #5579 case

#5706

Fix for #5579 Rails3 - accepts_nested_attributes_for reject_if option does not work. involved the code change for both has_one and has_many
relationships. The patch included test only for has_one. This patch
adds test for has_many relationship.

However because of a bug in the way nested_attribute works. This patch should be applied only after the patch for #5705 nested_attributes with has_many association doest not work when a single reco... has been applied.

Reported by Neeraj Singh · September 26th, 2010 @ 05:57 AM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Neeraj Singh
    Neeraj Singh
    • Assigned user set to José Valim
    • Tag set to patched

    September 26th, 2010 @ 05:59 AM

  2. Repository
    Repository
    • State changed from new to resolved

    (from [4966b915fe96db73933d33176c1ea5cc53e58a22]) Fix for #5579 Rails3 - accepts_nested_attributes_for reject_if option does not work. involved the code change for both has_one and has_many relationships. The path included test only for has_one. This patch adds test for has_many relationship.

    [#5706 add has_many test for #5579 case state:resolved]

    Signed-off-by: José Valim jose.valim@gmail.com
    http://github.com/rails/rails/commit/4966b915fe96db73933d33176c1ea5...

    September 27th, 2010 @ 10:12 PM

  3. José Valim
    José Valim
    • State changed from resolved to open
    • Milestone cleared.

    Neeraj, could you please provide a patch for 3-0-stable? Thanks! :D

    September 27th, 2010 @ 10:23 PM

  4. José Valim
  5. Neeraj Singh
    Neeraj Singh

    backport of 5579 and 5706 is attached.

    September 27th, 2010 @ 11:00 PM

  6. Repository
  7. Andrea Campi
    Andrea Campi
    • Tag changed from patched to activerecord, patch

    bulk tags cleanup

    October 11th, 2010 @ 07:22 AM

  8. Ryan Bigg
    Ryan Bigg
    • Tag cleared.

    Automatic cleanup of spam.

    October 11th, 2010 @ 12:10 PM

  9. Jeremy Kemper
  10. Ryan Bigg
    Ryan Bigg
    • Tag cleared.

    Automatic cleanup of spam.

    October 16th, 2010 @ 02:28 AM