This project is archived and is in readonly mode.
ShowExceptions renders original exceptions
Reported by Les Hill | October 11th, 2010 @ 04:14 PM
Current ShowExceptions middleware behavior is to use the wrapping exception to set the response. So all template errors are shown as 500's even when a 404 would be indicated from the wrapped exception.
This patch finds wrapped exceptions which have a response known to ShowExceptions and use that instead. If the wrapped exception is not known to ShowExceptions, the wrapping exception is used instead.
The original exception (i.e. the wrapping exception) continues to be logged.
Les Hill
Sandro Turriate
Comments and changes to this ticket
-
-
Santiago Pastorino October 11th, 2010 @ 04:59 PM
- Assigned user set to “José Valim”
- Importance changed from “” to “Low”
-
Repository October 11th, 2010 @ 11:56 PM
- State changed from “new” to “resolved”
(from [dde54f00c6c08d1704d011d8108106076e8ea033]) Show exceptions rescues the original exception
[#5784 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/dde54f00c6c08d1704d011d8108106...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Les Hill
sandro
Santiago Pastorino
Attachments
Tags
Referenced by
-
5784
ShowExceptions renders original exceptions
[#5784 state:resolved]