Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

send_file_headers! should get higher visibility or a public wrapper

#5866

Hello,
this is my use case.

We store files on a remote location (say Amazon S3).
When a user wants to stream a file we just redirect to the Amazon S3 file URL and that's fine.

However Safari/Mac is kinda broken in this regard:
http://stackoverflow.com/questions/1995589/html5-audio-safari-live-...
due to faulty range headers.

So my idea was to craft custom headers in our stream action and stream the file directly from our action.

In order to do that I need to call send_file_headers! with custom headers because send_data and send_file actually requires a file that resides on local filesystem and I want to avoid that.

The problem is that Ruby 1.9 doesn't allow to call private methods with send anymore.

I think publicizing up send_file_headers! or writing a public caller method would greatly increase the customization of the action if the developer know what he's doing.

  send_file_headers!(
    :length => S3Object.about(<s3 object>, <s3 bucket>)["content-length"],
    :filename=><the filename>
  )
  render :status => 200, :text => Proc.new { |response, output|
    S3Object.stream(<s3 object>, <s3 bucket>) do |chunk|
      output.write chunk
    end
  }

Also, in Rails 3 this method is considerably different, we may have to take care of that, for example :length is not used anymore.

Reported by Claudio Poli · October 26th, 2010 @ 06:59 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • Importance changed from to Low

    Automatic cleanup of spam.

    November 1st, 2010 @ 05:06 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:20 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:20 PM