This project is archived and is in readonly mode.

#6172 ✓stale
Matthew Ratzloff

Asset change broke engine asset expansions slightly

Reported by Matthew Ratzloff | December 15th, 2010 @ 06:48 PM | in 3.1

This recent commit

https://github.com/rails/rails/commit/0e5ee9af48f11201a3b06fb3f5a50144224ec9e8

broke our engine expansions slightly. We do not do use :all for expansions, but rather require specific groups. For some reason, we needed to explicitly add filename extensions (.css, .js) to our expansions after this change. After that (and with the fix outlined in https://rails.lighthouseapp.com/projects/8994/tickets/6114) they work.

Comments and changes to this ticket

  • Piotr Sarnacki

    Piotr Sarnacki December 16th, 2010 @ 07:25 AM

    • Milestone set to 3.1
    • State changed from “new” to “open”
    • Assigned user set to “Piotr Sarnacki”
    • Importance changed from “” to “Low”
  • Piotr Sarnacki

    Piotr Sarnacki December 22nd, 2010 @ 09:03 AM

    • State changed from “open” to “incomplete”

    Matthew: could you provide failing test or engine example that will show the issue on master?

    I added a test for engines to check that and it passes on master: https://github.com/drogus/rails/commit/b4090cd77e57d07f4ccc44438759...

  • rails

    rails March 23rd, 2011 @ 12:00 AM

    • State changed from “incomplete” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails March 23rd, 2011 @ 12:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages