#674 validations_test.rb: tests make changes to models without reverting them - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#674 ✓resolved

validations_test.rb: tests make changes to models without reverting them

Reported by Murray Steele | July 22nd, 2008 @ 02:55 PM | in 2.x

Most of the tests in validations_tests take an existing model, give it a new validation and then do some asserts to make sure that the validations work. There is code in setup to blank out the validations for Topic (the model used in most of the tests), however, other models are used and they are not being revertted.

The problem is that any test that is run after validations_test may encounter problems where models can't be saved because of the validations added by validations_test.

Also, the current method of simply zero-ing the validations for Topic before each test isn't the best case for this because Topic does have some default validations (has_many :replies adds a default validate_associated_records_for_replies), so the state of the Topic model going into these validations_tests is wrong. It's also wrong after the last validation_test as either anything that happens inside that test will not be reverted or the default Topic validations are not reset.

The attached patch provides a repair_helper for activerecord tests that currently knows how to:

a) repair validations: will record the validation state of a model class, execute the block and then reset the validations afterward.

b) repair default error messages: will record the default error messages inside ActiveRecord::Errors, execute the block and then reset the default error messages.

These can be called with a block inside a test, or without a block in the context of a test case to supply default setup / teardown callbacks to do the same.

Comments and changes to this ticket

Pratik October 4th, 2008 @ 02:42 PM
- State changed from “new” to “incomplete”
Hey Murray,

I think you forgot to include the definition of repair_validations method.
You flagged this item as spam.
Murray Steele October 26th, 2008 @ 03:30 PM
You're right, I'm an idiot. Attaching a new version. Although this version no longer includes the repair_default_error_messages stuff because I haven't looked into the new i18N stuff.
- provide_repair_helper_and_make_validations_tests_use_it.patch 26 KB
Pratik December 18th, 2008 @ 09:33 PM
- State changed from “incomplete” to “open”
Repository December 19th, 2008 @ 01:42 PM
- State changed from “open” to “resolved”
(from [8a92cdc8638d1f91aaa55fc47743a6210ad2181b]) Add a repair_helper to repair changes to the validations inside validations_test.rb [#674 state:resolved]

Many of the tests in validations_test would add a new validation to models. However, only Topic was being reset with a fairly aggressive clearing of all validations. None of the other models being used however were recieving the same treatment. Now we use repair_validations(Topic) for the whole test case because most test cases use Topic and then the block form of repair_validations(<other_models>) inside any tests that use other models.

Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...