Rails Ruby on Rails → 2.x

While persnickety, there is a flaw in the setter for original filename, in Rails 2.1.0, in an apache/passenger setup.

The filename on the next line:

&;()<>|!{}[]'"*?~\$`.ext

for example, comes out as

&;()<>|!{}[]'

Note that the leading space, and everything trailing the single-quote (at the double-quote position) is truncated.

We recently migrated from Mongrel, where we had hand-rolled our own upload filename grabber, to Passenger, and wanted to use the nice mod_upload_progress that exists out there. The code we used was /BAD/, but looked like this:

temp = e.split('=')

if temp[0] == "filename"

1. remove begin/end double-quotes, without
2. munging double-quotes in the filename

filename = temp[1].chomp().chop().reverse().chop().reverse()

puts "filename: #{filename}" if @debug

end

This preserved the filename perfectly -- we also later massaged out the IE full-path to get just the basename.

So, while filename that has all those characters is unlikely, it's indeed a valid filename, and should be preserved.