This project is archived and is in readonly mode.
Specifying timestamps in a migration does not honor options
-
Matt Swasey
+1
Looks good!
-
Pratik
- State changed from new to incomplete
Patch doesn't apply cleanly. Could you please upload a new patch against latest edge ? Also, no need to use with_options in the tests. And tests should test if the column was successfully created with specified options.
Thanks.
-
Patrick Reagan
This updated patch should address your comments - I was able to apply the new one against the latest Edge (got a couple whitespace warnings). I also squashed the changeset down to a single commit to cut down on the noise.
-
Repository
- State changed from incomplete to resolved
(from [683ff235e6b81d28962f5a71ff53730a1c118fc8]) Ensure t.timestamps respects options. [#828 Specifying timestamps in a migration does not honor options state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
-
Repository
(from [9c11b96c721e0aef3186e67ed1c9fdd172488668]) Ensure t.timestamps respects options. [#828 Specifying timestamps in a migration does not honor options state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
