This project is archived and is in readonly mode.

Changeset [03749d6c88ae8312dc959b7683851dbf8c969326] by Tom Stuart

February 12th, 2011 @ 03:51 PM

Make type="submit" the default for button_tag helper

"submit" is the default value of the element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag
is going to have a default, type="submit" is a more sensible choice than
type="button".

http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON
http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type

Signed-off-by: Santiago Pastorino and Emilio Tagua santiago+emilioe@wyeworks.com
https://github.com/rails/rails/commit/03749d6c88ae8312dc959b7683851...

Committed by Tom Stuart

  • M actionpack/lib/action_view/helpers/form_tag_helper.rb
  • M actionpack/test/template/form_tag_helper_test.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>