This project is archived and is in readonly mode.

Changeset [11af089cee0a0e744e267d32becfe2c66a586d31] by Joshua Peek

May 3rd, 2009 @ 05:02 AM

Extract ActionController rescue templates into Rescue and ShowExceptions middleware.

This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. http://github.com/rails/rails/co...

Committed by Joshua Peek

  • M actionpack/lib/action_controller.rb
  • M actionpack/lib/action_controller/base/base.rb
  • M actionpack/lib/action_controller/base/rescue.rb
  • M actionpack/lib/action_controller/dispatch/dispatcher.rb
  • M actionpack/lib/action_controller/dispatch/middlewares.rb
  • M actionpack/lib/action_controller/dispatch/rescue.rb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/_request_and_response.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/_trace.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/diagnostics.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/layout.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/missing_template.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/routing_error.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/template_error.erb
  • M actionpack/lib/action_controller/dispatch/templates/rescues/unknown_action.erb
  • M actionpack/lib/action_dispatch.rb
  • M actionpack/lib/action_dispatch/middleware/rescue.rb
  • M actionpack/lib/action_dispatch/middleware/show_exceptions.rb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/layout.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/missing_template.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/routing_error.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/template_error.erb
  • M actionpack/lib/action_dispatch/middleware/templates/rescues/unknown_action.erb
  • M actionpack/lib/action_dispatch/testing/assertions/response.rb
  • M actionpack/test/controller/action_pack_assertions_test.rb
  • M actionpack/test/controller/base_test.rb
  • M actionpack/test/controller/caching_test.rb
  • M actionpack/test/controller/deprecation/deprecated_base_methods_test.rb
  • M actionpack/test/controller/dispatcher_test.rb
  • M actionpack/test/controller/filters_test.rb
  • M actionpack/test/controller/layout_test.rb
  • M actionpack/test/controller/rescue_test.rb
  • M actionpack/test/dispatch/show_exceptions_test.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>