Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Changeset [1b3195b63ca44f0a70b61b75fcf4991cb2fbb944] by Phil Darnowsky

Revision 1b3195b63ca44f0a70b61b75fcf4991cb2fbb944, committed by Phil Darnowsky · October 14th, 2009 @ 09:49 PM

ActionView.url_for doesn't escape by default

ActionView::Helpers::UrlHelper#url_for used to escape the URLs it generated by
default. This was most commonly seen when generating a path with multiple
query parameters, e.g.

url_for(:controller => :foo, :action => :bar, :this => 123, :that => 456)

would return

http://example.com/foo/bar?that=456&this=123

escaping an ampersand that shouldn't be escaped. This is both wrong and
inconsistent with the behavior of ActionController#url_for, and is changed.

Signed-off-by: Michael Koziarski michael@koziarski.com
http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf499...

2 changed files

  • M actionpack/lib/action_view/helpers/url_helper.rb
  • M actionpack/test/template/url_helper_test.rb