This project is archived and is in readonly mode.

Changeset [75b32a69a185e2e802934bc4000f6c0efbc5c2e7] by Wincent Colaiuta

July 3rd, 2010 @ 09:42 PM

Fixes for "router" and "routes" terminology

Commit f7ba614c2db improved the internal consistency of the different
means of accessing routes, but it introduced some problems at the level
of code comments and user-visible strings.

This commit applies fixes on three levels:

Firstly, we remove or replace grammatically invalid constructs such as
"a routes" or "a particular routes".

Secondly, we make sure that we always use "the router DSL" or "the
router syntax", because this has always been the official terminology.

Finally, we make sure that we only use "routes" when referring to the
application-specific set of routes that are defined in the
"config/routes.rb" file, we use "router" when referring on a more abstract level to "the code in Rails used to handle routing", and we use
"routing" when we need an adjective to apply to nouns such as "url_helpers. Again this is consistent with historical practice and other places in the documentation.

Note that this is not a sweep over the entire codebase to ensure
consistent usage of language; it is just a revision of the changes
introduced in commit f7ba614c2db.

Signed-off-by: Wincent Colaiuta win@wincent.com
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/75b32a69a185e2e802934bc4000f6c...

Committed by Wincent Colaiuta

  • M actionmailer/lib/action_mailer/base.rb
  • M actionpack/lib/action_controller/deprecated/base.rb
  • M actionpack/lib/action_controller/metal.rb
  • M actionpack/lib/action_controller/metal/url_for.rb
  • M actionpack/lib/action_dispatch/routing/deprecated_mapper.rb
  • M actionpack/lib/action_dispatch/routing/mapper.rb
  • M actionpack/lib/action_dispatch/routing/route_set.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>