This project is archived and is in readonly mode.

Changeset [bdec56cbe74c53482f150829f735e45e9f7afeb7] by Carlos Antonio da Silva

November 13th, 2010 @ 03:06 PM

Fix rendering partial with layout, when the partial contains another render layout with block call

In such situations, the first layout was not being applied. This fixes it by
storing the block variable before rendering the partial, so the variable
is not overrided, thus the layout is applied (bear in mind the renderer is
shared among all render calls).

This commit also adds some more tests to render partials with layouts and
nested render layout calls.

Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/bdec56cbe74c53482f150829f735e...

Committed by Carlos Antonio da Silva

  • A actionpack/test/fixtures/test/_partial_with_layout.erb
  • A actionpack/test/fixtures/test/_partial_with_layout_block_content.erb
  • A actionpack/test/fixtures/test/_partial_with_layout_block_partial.erb
  • M actionpack/lib/action_view/render/partials.rb
  • M actionpack/test/template/render_test.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>