This project is archived and is in readonly mode.

Changeset [ebee77a28a7267d5f23a28ba23c1eb88a2d7d527] by Michael Lovitt

June 27th, 2010 @ 09:39 PM

Fixed that an ArgumentError is thrown when request.session_options[:id] is read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types.

[#4938]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/ebee77a28a7267d5f23a28ba23c1eb...

Committed by Michael Lovitt

  • A actionpack/test/fixtures/session_autoload_test/session_autoload_test/foo.rb
  • M actionpack/lib/action_dispatch/middleware/session/abstract_store.rb
  • M actionpack/lib/action_dispatch/middleware/session/cookie_store.rb
  • M actionpack/test/abstract_unit.rb
  • M actionpack/test/dispatch/session/cookie_store_test.rb
  • M actionpack/test/dispatch/session/mem_cache_store_test.rb

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>